[HTML5] Fix audio buffer size and latency hint. #43358
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the audio buffer was incorrectly doubled when creating the script processor. latencyHint is expressed in seconds, not milliseconds. Additionally, on some browsers it actually affect the performance and stability of the audio driver. For this reason it has been completely disabled (interactive) and a not has been left for future reference.
Faless
added
bug
platform:web
topic:porting
topic:audio
regression
cherrypick:3.x
akien-mga
approved these changes
Nov 6, 2020
|
Thanks! |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-pick included in #43454. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the audio buffer was incorrectly doubled when creating the script processor.
latencyHintis expressed in seconds, not milliseconds.Additionally, on some browsers it actually affect the performance and stability of the audio driver.
For this reason it has been completely disabled (interactive) and a not has been left for future reference.
Fixes: #43210